Open
Conversation
mchack-work
force-pushed
the
signify-methods
branch
3 times, most recently
from
55951e6 to
e1e3779
Compare
9 tasks
- Make public key and signatures available externally. - Add methods to import and export these types to and from buffers and files. - Add tests for parsing and generating. - Move writeRetry() to util.go - Signify uses "Ed", we use "Eb", indicating to us that our message should be hashed with BLAKE2s.
mchack-work
force-pushed
the
signify-methods
branch
2 times, most recently
from
b751852 to
74bf928
Compare
- Clean up the main function and hide the complexities of all the commands in their own functions. Also reduces the cyclomatic complexity. - Hide some args, like device path, device speed, USS filename and request USS from user, in structs.
mchack-work
force-pushed
the
signify-methods
branch
from
d26286c to
2dd940a
Compare
- Introduce new function getMessage() that produces the message to be signed or verified. - Use message produced by getMessage() in Sign() and Verified() and dependent helper functions.
Choose hash algorithm to use with -a/--alg. Options are "ed" (default, SHA-512) and "b2s" (BLAKE2s).
mchack-work
changed the title
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make Signify types like public key and signatures available externally, for instance for use in
sign-tool,tkey-mgt,tkeyimageand the like. And, of course, external project who would like to read and write to these this kind of files.Write methods to handle import and export more gracefully.
Add tests for signify methods.
Change the
tkey-signcommand accordingly.Add support for choice of hash algoritm (
-aflag)Add support for BLAKE2s algorithm.
Fixes #36
See also:
Type of change
Submission checklist